-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rhombic & deltoidal #60
Conversation
@rbathoorn this integrates your code, with a few tweaks:
I wonder if we could shorten the names of the two new projections. The complete (& accurate) geometric description is a bit long. The default aspect of the rhombic dodecahedral might need some more thought. It would be more readable with the North pole at the top? Note that because of the new rhombic dodecahedral projection, the previously "geoDodecahedral" projection should be “pentagonal dodecahedral" :) But I don't plan to change its symbol. Another remark is that the polyhedral/ sub-directory is now a bit inconsistent… maybe we should flatten everything since most of these projections are polyhedral? |
Look better indeed. And the names of the functions could be shortened to something like geoRhombic and geoDeltoidal I just put in the whole names as all the previous ones also had the complete names :) |
local copy of #59 ;
closes #57
closes #39
deltoidal hexecontahedral
rhombic dodecahedral